Conversation
Member
|
|
|
The binary size change of libncnn.so (bytes)
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Windows CI workflow from using a matrix of different Windows runners (windows-2019 and windows-2022) to exclusively use windows-2022, requiring additional setup steps to support older Visual Studio toolsets.
- Consolidates all builds to run on windows-2022 instead of using different OS versions
- Adds installation steps for VS 2015 and VS 2017 build tools since they're not pre-installed on windows-2022
- Splits a long cmake command into multiple lines for better readability
nihui
approved these changes
Jul 25, 2025
Member
|
Thanks for your contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.