Skip to content

riscv: implement rvv optimized tan operator#6460

Merged
nihui merged 1 commit intoTencent:masterfrom
ihb2032:opt/tan-rvv
Dec 23, 2025
Merged

riscv: implement rvv optimized tan operator#6460
nihui merged 1 commit intoTencent:masterfrom
ihb2032:opt/tan-rvv

Conversation

@ihb2032
Copy link
Contributor

@ihb2032 ihb2032 commented Dec 21, 2025

This is a follow-up to #6436. I've applied the macro fix as suggested by @nihui to exclude xtheadvector, ensuring precision while keeping the optimization for standard RVV 1.0.

@github-actions github-actions bot added the riscv label Dec 21, 2025
@ihb2032 ihb2032 changed the title This is a follow-up to #6436. I've applied the macro fix as suggested by @nihui to exclude xtheadvector, ensuring precision while keeping the optimization for standard RVV 1.0. riscv: implement rvv optimized tan operator Dec 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.90%. Comparing base (d1eb400) to head (e793dac).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6460      +/-   ##
==========================================
+ Coverage   95.69%   95.90%   +0.20%     
==========================================
  Files         844      844              
  Lines      264779   265697     +918     
==========================================
+ Hits       253393   254821    +1428     
+ Misses      11386    10876     -510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@nihui nihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vfloat32m8_t operator()(const vfloat32m8_t& x, const size_t& vl) const
{
#if __riscv_xtheadvector
    // fallback
#else
    // rvv opt
#endif
}

Signed-off-by: ihb2032 <[email protected]>
Co-authored-by: lyd1992 <[email protected]>
@nihui nihui merged commit 39003ec into Tencent:master Dec 23, 2025
52 checks passed
@nihui
Copy link
Member

nihui commented Dec 23, 2025

Thanks for your contribution !

@ihb2032 ihb2032 deleted the opt/tan-rvv branch December 23, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants