Fix inspect(sort=False) to preserve instance attribute order #3914
+27
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
inspect(sort=False)did not preserve theinsertion order of instance attributes.
Previously, instance attributes were always displayed in alphabetical order
because
dir(obj)returns a sorted list of attribute names. This behaviorignored the
sort=Falseoption.To fix this, when
sort=Falseand the object has a__dict__, the instanceattribute insertion order is used instead of
dir(obj).A test was added to ensure the attribute order is preserved when
sort=False.