fix(markdown): Correctly render loose lists with blank lines #3916
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously,
Richrendered all Markdown lists as "tight" lists, even when items were separated by blank lines (loose lists). This squashed list items together, ignoring the intended vertical spacing defined in the CommonMark spec.Solution
I updated the
ListItemclass inrich/markdown.pyto respect thehiddenattribute provided by themarkdown-it-pyparser.ListItem.on_child_closeprocesses a child element, it now checks if that child is explicitly marked as "visible" (not token.hidden).Text(" ")) is appended to the renderable elements.tests/test_markdown.pyandtests/test_markdown_no_hyperlinks.pyto reflect the corrected, spaced-out rendering. This ensures no regressions for standard (tight) lists while fixing the output for loose lists.Example
Input: