Run clang-tidy with nice if configured.#10369
Merged
maliberty merged 1 commit intoMay 10, 2026
Merged
Conversation
... configuration default on. I noticed while running clang-tidy in the background, that it otherwise bogs down the PC while doing other stuff. Signed-off-by: Henner Zeller <h.zeller@acm.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a run_with_nice configuration option to execute clang-tidy via the Unix nice command, preventing it from consuming excessive system resources. Feedback suggests enhancing this feature by allowing an environment variable override (CLANG_TIDY_NICE) to maintain consistency with existing configuration patterns in the script.
maliberty
approved these changes
May 10, 2026
maliberty
merged commit 56b3158
into
The-OpenROAD-Project:master
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... configuration default on.
I noticed while running clang-tidy in the background, that it otherwise bogs down the PC while doing other stuff.