gpl: fix options and cleanup readme#10406
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new timing-driven net percentage parameter to the global placement configuration, updates the documentation, and adds corresponding validation logic and tests. The review identified several issues, including incorrect validation ranges for padding and coefficient parameters, typos in documentation and parameter names, and inconsistencies in the newly added test scripts. All review comments provide actionable feedback and have been retained.
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
760149f to
5ac8b2d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
5ac8b2d to
3d25a22
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
3d25a22 to
10d37bd
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
10d37bd to
ce1bbd9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
ce1bbd9 to
7ff19c4
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Tobias Senti <git@tsenti.li>
TheMightyDuckOfDoom
force-pushed
the
gpl-fix-timing_driven_nets_percentage
branch
from
7ff19c4 to
0487a95
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
| | `-init_density_penalty` | Set initial density penalty. The default value is `8e-5`. Allowed values are floats `[1e-6, 1e6]`. | | ||
| | `-init_wirelength_coef` | Set initial wirelength coefficient. The default value is `0.25`. Allowed values are floats. | | ||
| | `-min_phi_coef` | Set `pcof_min` ($\mu_k$ Lower Bound). The default value is `0.95`. Allowed values are floats `[0.95, 1.05]`. | | ||
| | `-min_phi_coef` | Set `pcof_min` ($\mu_k$ Lower Bound). The default value is `0.95`. Suggested values are positive floats `[0.95, 1.05]`. | |
There was a problem hiding this comment.
Does it work if we do values outside of the suggested range? the max_phi_coef was kept with "allowed"
2 participants
This fixes a few issues with GPL options:
-disable_timing_drivenand-disable_routability_driven-timing_driven_nets_percentage