Skip to content

ScheduledTasks improve error handling and disable multiple tasks with same name #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvarian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ScheduledTasks improve error handling and disable multiple tasks with same name #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions Windows_VDOT.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Param (
- AUTHORED BY: Robert M. Smith and Tim Muessig (Microsoft)
- AUTHORED DATE: 11/19/2019
- CONTRIBUTORS: Travis Roberts (2020), Jason Parker (2020), @brentil (2024)
- LAST UPDATED: 6/14/2024
- LAST UPDATED: 9/12/2025
- PURPOSE: To automatically apply many optimization settings to and Windows device; VDI, AVD, standalone machine

- Important: Every setting in this script and input files are possible optimizations only,
Expand Down Expand Up @@ -294,29 +294,34 @@ PROCESS {
{
Foreach ($Item in $SchTasksList)
{
$TaskObject = Get-ScheduledTask $Item.ScheduledTask
If ($TaskObject -and $TaskObject.State -ne 'Disabled')
{
Write-EventLog -EventId 30 -Message "Attempting to disable Scheduled Task: $($TaskObject.TaskName)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Information
Write-Verbose "Attempting to disable Scheduled Task: $($TaskObject.TaskName)"
$Tasks = Get-ScheduledTask -TaskName $Item.ScheduledTask -ErrorAction SilentlyContinue

if (-not $Tasks) {
Write-EventLog -EventId 130 -Message "Scheduled Task not found: $($Item.ScheduledTask)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Warning
continue
}

foreach ($TaskObject in @($Tasks)) {
$taskIdentifier = "$($TaskObject.TaskPath)$($TaskObject.TaskName)"

If ($TaskObject.State -eq 'Disabled')
{
Write-EventLog -EventId 30 -Message "$taskIdentifier Scheduled Task is already disabled" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Information
continue
}

Write-EventLog -EventId 30 -Message "Attempting to disable Scheduled Task: $taskIdentifier" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Information
Write-Verbose "Attempting to disable Scheduled Task: $taskIdentifier"
try
{
Disable-ScheduledTask -InputObject $TaskObject | Out-Null
Write-EventLog -EventId 30 -Message "Disabled Scheduled Task: $($TaskObject.TaskName)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Information
Disable-ScheduledTask -InputObject $TaskObject -ErrorAction Stop | Out-Null
Write-EventLog -EventId 30 -Message "Disabled Scheduled Task: $taskIdentifier" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Information
}
catch
{
Write-EventLog -EventId 130 -Message "Failed to disabled Scheduled Task: $($TaskObject.TaskName) - $($_.Exception.Message)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Error
Write-EventLog -EventId 130 -Message "Failed to disable Scheduled Task: $taskIdentifier - $($_.Exception.Message)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Error
}
}
ElseIf ($TaskObject -and $TaskObject.State -eq 'Disabled')
{
Write-EventLog -EventId 30 -Message "$($TaskObject.TaskName) Scheduled Task is already disabled - $($_.Exception.Message)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Warning
}
Else
{
Write-EventLog -EventId 130 -Message "Unable to find Scheduled Task: $($TaskObject.TaskName) - $($_.Exception.Message)" -LogName 'Virtual Desktop Optimization' -Source 'ScheduledTasks' -EntryType Error
}
}
}
Else
Expand Down