-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
adding a proper fractions algorithm #11224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cclauss
merged 10 commits into
TheAlgorithms:master
from
meg-1:proper_fractions_with_denom
Mar 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8c6fe27
adding a proper fractions algorithm
meg-1 298768a
Implementing suggestions in maths/numerical_analysis/proper_fractions.py
meg-1 b6f624c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a01f100
Implementing suggestions to proper_fractions.py
meg-1 f71b575
Fixing ruff errors in proper_fractions.py
meg-1 2413468
Apply suggestions from code review
cclauss 0c65134
ruff check --output-format=github .
cclauss 9ee43a0
Update maths/numerical_analysis/proper_fractions.py
cclauss f4147ad
Merge branch 'master' into proper_fractions_with_denom
cclauss a46940e
Update proper_fractions.py
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
def gcd(numerator: int, denominator: int) -> int: | ||
""" | ||
>>> gcd(12, 18) | ||
6 | ||
>>> gcd(20, 25) | ||
5 | ||
>>> gcd(20, 0) | ||
Traceback (most recent call last): | ||
ValueError: The Denominator cannot be 0 | ||
""" | ||
if denominator == 0: | ||
raise ValueError("The Denominator cannot be 0") | ||
while denominator: | ||
numerator, denominator = denominator, numerator % denominator | ||
return numerator | ||
|
||
|
||
def proper_fractions(denominator: int) -> list[str]: | ||
""" | ||
this algorithm returns a list of proper fractions, in the | ||
range between 0 and 1, which can be formed with the given denominator | ||
>>> proper_fractions(10) | ||
['1/10', '3/10', '7/10', '9/10'] | ||
>>> proper_fractions(5) | ||
['1/5', '2/5', '3/5', '4/5'] | ||
>>> proper_fractions(-15) | ||
meg-1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Traceback (most recent call last): | ||
ValueError: The Denominator Cannot be less than 0 | ||
>>> | ||
""" | ||
|
||
if denominator < 0: | ||
raise ValueError("The Denominator Cannot be less than 0") | ||
fractions: list[str] = [] | ||
for numerator in range(1, denominator): | ||
if gcd(numerator, denominator) == 1: | ||
fractions.append(f"{numerator}/{denominator}") | ||
return fractions | ||
meg-1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
if __name__ == "__main__": | ||
__import__("doctest").testmod() | ||
meg-1 marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.