Skip to content

Fix ruff #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 25, 2024
Merged

Fix ruff #11527

merged 11 commits into from
Aug 25, 2024

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 25, 2024
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Aug 25, 2024
@MaximSmolskiy MaximSmolskiy requested a review from cclauss as a code owner August 25, 2024 12:53
This reverts commit 5bc3bf3.
@MaximSmolskiy
Copy link
Member Author

@cclauss please review

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 25, 2024
@cclauss
Copy link
Member

cclauss commented Aug 25, 2024

I suspect using max() and min() is slower than the code that they replace. It is more readable but is it worth the slowdown?

We should probably use a noqa to avoid this rule in maths/find_max.py because not using max() is the goal of that file.

@cclauss
Copy link
Member

cclauss commented Aug 25, 2024

More than 4x slower...

def countdown_max():
    j = -1
    for i in range(1_000_000, 0, -1):
        j = max(i, j)
    return j


def countdown_maximum():
    j = -1
    for i in range(1_000_000, 0, -1):
        if j < i:
            j = i
    return j


def countup_max():
    j = -1
    for i in range(1_000_000):
        j = max(i, j)
    return j


def countup_maximum():
    j = -1
    for i in range(1_000_000):
        if j < i:
            j = i
    return j


if __name__ == "__main__":
    from timeit import timeit

    print(f"{countdown_max() = }")
    print(f"{countdown_maximum() = }")
    print(f"{countup_max() = }")
    print(f"{countup_maximum() = }\n")

    print("countdown_max", timeit("countdown_max()", globals=globals(), number=10))
    print("countdown_maximum", timeit("countdown_maximum()", globals=globals(), number=10))
    print("countup_max", timeit("countup_max()", globals=globals(), number=10))
    print("countup_maximum", timeit("countup_maximum()", globals=globals(), number=10))

@cclauss cclauss merged commit e3fa014 into TheAlgorithms:master Aug 25, 2024
5 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-ruff branch August 25, 2024 15:33
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
* updating DIRECTORY.md

* Fix ruff

* Fix

* Fix

* Fix

* Revert "Fix"

This reverts commit 5bc3bf3.

* find_max.py: noqa: PLR1730

---------

Co-authored-by: MaximSmolskiy <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
* updating DIRECTORY.md

* Fix ruff

* Fix

* Fix

* Fix

* Revert "Fix"

This reverts commit 5bc3bf3.

* find_max.py: noqa: PLR1730

---------

Co-authored-by: MaximSmolskiy <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
* updating DIRECTORY.md

* Fix ruff

* Fix

* Fix

* Fix

* Revert "Fix"

This reverts commit 5bc3bf3.

* find_max.py: noqa: PLR1730

---------

Co-authored-by: MaximSmolskiy <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants