Skip to content

feat: add test cases in cipher's autokey #11881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: add test cases in cipher's autokey #11881

merged 1 commit into from
Oct 8, 2024

Conversation

zeelrupapara
Copy link
Contributor

Describe your change:

  • Add test cases in cipher's autokey algorithms and increase the coverage by around 10%
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 8, 2024
@zeelrupapara
Copy link
Contributor Author

hi @kalvarahul Are you forgot to merged the PR?

@kalvarahul
Copy link

I was reviewing the code, the owner will merge it

@zeelrupapara
Copy link
Contributor Author

I was reviewing the code, the owner will merge it

Ok maybe @cclauss or @tianyizheng02 gonna merged it

@cclauss cclauss enabled auto-merge (squash) October 8, 2024 11:33
@cclauss cclauss merged commit 260e3d8 into TheAlgorithms:master Oct 8, 2024
3 checks passed
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@kalvarahul kalvarahul kalvarahul approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeelrupapara @kalvarahul @cclauss