Skip to content

add generic list type hints to double_linear_search_recursion - #15489

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
shriya-97:fix-code-quality
Oct 4, 2026
Merged

cclauss merged 6 commits into
TheAlgorithms:masterfrom
shriya-97:fix-code-quality

Conversation

@shriya-97

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 3, 2026
-1
"""
right = right or len(list_data) - 1
if left > right:

@cclauss cclauss Oct 4, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any is not correct in this instance because line 25 uses gt and line 27 uses eq so we need to define a type that is Comparable as discussed at #15490 (review)

You can add a dataclass and doctests to prove this.

from dataclasses import dataclass


@dataclass()
class Person:
    first_name: str

    # __gt__ = None  # if you uncomment either of these lines then the new doctests start to fail.
    # __eq__ = None

### Add to `search()` doctests...

    >>> search([Person("Al"), Person("Bob"), Person("Carl")], Person("Bob"))
    1
    >>> search([Person("Al"), Person("Bob"), Person("Carl")], "Bob")
    -1

You will need to create a Comparable type as discussed in:

@algorithms-keeper algorithms-keeper Bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 4, 2026
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 4, 2026
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass labels Oct 4, 2026
Comment thread searches/double_linear_search_recursion.py Outdated
Comment thread searches/double_linear_search_recursion.py Outdated
Comment thread searches/double_linear_search_recursion.py Outdated
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2026
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 4, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 4, 2026
@cclauss
cclauss merged commit 51c2f53 into TheAlgorithms:master Oct 4, 2026
6 checks passed
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants