Skip to content

fixing error #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fixing error #1964

wants to merge 3 commits into from

Conversation

itsvinayak
Copy link
Member

@itsvinayak itsvinayak commented May 9, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak itsvinayak requested a review from cclauss May 9, 2020 20:01
@itsvinayak
Copy link
Member Author

@cclauss there was an error in maths/kadanes_algorithm.py now solved

@TheAlgorithms TheAlgorithms deleted a comment from aungkohein097 May 9, 2020
@itsvinayak itsvinayak requested a review from poyea May 10, 2020 04:38
@cclauss
Copy link
Member

cclauss commented May 10, 2020

Closing in favor of #1966 which fixes single character variable names.

@cclauss cclauss closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss

@poyea poyea Awaiting requested review from poyea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsvinayak @cclauss