Skip to content

Added type hint where possible and default argument problem 234 project euler #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sondrbw
Copy link

@sondrbw sondrbw commented Oct 9, 2020

fib has inconsistent return type so no hints added there

this fix is according to issue #2786

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #2786.

fib has inconsistent return type so no hints added there
@sondrbw sondrbw changed the title Added type hint where possible and default argument Added type hint where possible and default argument problem 234 project euler Oct 9, 2020
@TravisBuddy
Copy link

Hey @sondrewang,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c8ccb190-0a0e-11eb-b8c5-47e0b209ea74

@dhruvmanila
Copy link
Member

For this specific solution, it's not going to be this simple. You will have to change the solution completely as it requires input from the user. So, if you're up for the challenge, go on otherwise you can close this PR.

@sondrbw sondrbw closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants