-
Notifications
You must be signed in to change notification settings - Fork 33
Labels
A-CLIRelated to the main CLI and not a more specific subcommandRelated to the main CLI and not a more specific subcommandC-Code-QualityAn improvement of readability or qualityAn improvement of readability or qualityS-Ready-for-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Milestone
Description
Our current code for parsing the CLI config from the Config.toml metadata leaves much to be desired.
We have hand-written all of the parsing logic given the different TOML data, which results in quite a bit of duplicated code and not very helpful error messages.
We should look into how we can improve this.
One idea would be to leverage serde to handle this for us.
We could keep getting the correct metadata segments for the platform and profile via the TOML data, then convert it back to a string and let serde to the conversion to our config data.
Sub-issues
Metadata
Metadata
Assignees
Labels
A-CLIRelated to the main CLI and not a more specific subcommandRelated to the main CLI and not a more specific subcommandC-Code-QualityAn improvement of readability or qualityAn improvement of readability or qualityS-Ready-for-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!