-
Notifications
You must be signed in to change notification settings - Fork 33
Fix determining artifact folder for dev profile #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DaAlbrecht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! bevy build runs for my test project successfully too.
|
Clippy: We could also unwrap this else block: https://github.com/TheBevyFlock/bevy_cli/blob/main/src/run/mod.rs#L191 |
BD103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally! Merge this when you're ready :)
What do you mean by unwrap here? |
In the |
Ah right, because |
Objective
Closes #218.
For some reason, the profile
devhas a target folder nameddebuginstead ofdev.This caused a compile error on native dev builds.
Solution
devprofileTesting
Run
bevy buildon a Bevy project, using this branch for the Bevy CLI.It shouldn't fail with an error.
Future work
We should probably set up some more tests for the CLI, testing all the build and run commands and potentially different targets and profiles.
But that would require non-trivial setup work, so I will defer it for a future task.