Compile bug: error C2065: 'M_PI' : undeclared identifier on Windows 11

[NERVxxxx]

Git commit

x

Operating systems

Windows

GGML backends

CUDA

Problem description & steps to reproduce

Hello,

I'm trying to compile on windows 11 but have an error. I tried on Linux and its working ...

Here what I did :
git clone https://github.com/TheTom/llama-cpp-turboquant.git : OK
cd llama-cpp-turboquant : OK
git checkout feature/turboquant-kv-cache : OK
cmake -B build -DGGML_CUDA=ON -DCMAKE_BUILD_TYPE=Release : OK
cmake --build build -j : NOK

...
Building Custom Rule C:/Users/user/Downloads/llama-cpp-turboquant/tools/mtmd/CMakeLists.txt
C:\Users\user\Downloads\llama-cpp-turboquant\ggml\src\ggml-turbo-quant.c(61,45): error C2065: 'M_PI' : identificateur non déclaré [C:\Users\user\Downloads\llama-cpp-turboquant\build\ggml\src\ggml-base.vcxpr
oj]
Building Custom Rule C:/Users/user/Downloads/llama-cpp-turboquant/tools/mtmd/CMakeLists.txt
...

Can you help me ?

First Bad Commit

No response

Compile command

cmake --build build -j

Relevant log output

Building Custom Rule C:/Users/user/Downloads/llama-cpp-turboquant/tools/mtmd/CMakeLists.txt
C:\Users\user\Downloads\llama-cpp-turboquant\ggml\src\ggml-turbo-quant.c(61,45): error C2065: 'M_PI' : identificateur non déclaré [C:\Users\user\Downloads\llama-cpp-turboquant\build\ggml\src\ggml-base.vcxpr
oj]
Building Custom Rule C:/Users/user/Downloads/llama-cpp-turboquant/tools/mtmd/CMakeLists.txt

[Gwynevere]

same problem for me, Win 11

[AntNoHuabei]

-DCMAKE_C_FLAGS="-D_USE_MATH_DEFINES" -DCMAKE_CXX_FLAGS="-D_USE_MATH_DEFINES"

[NERVxxxx]

Thank you for your help. Now I have this error :
ops.obj : error LNK2001: symbole externe non résolu "int turbo3_cpu_wht_group_size" (?turbo3_cpu_wht_group_size@@3HA) [ C:\Users\user\Downloads\llama-cpp-turboquant\build\ggml\src\ggml-cpu.vcxproj] ops.obj : error LNK2001: symbole externe non résolu "int turbo3_cpu_wht_group_size" (?turbo3_cpu_wht_group_size@@3HA) [ C:\Users\user\Downloads\llama-cpp-turboquant\build\ggml\src\ggml-cpu.vcxproj] C:\Users\user\Downloads\llama-cpp-turboquant\build\bin\Debug\ggml-cpu.dll : fatal error LNK1120: 1 externes non résolu s [C:\Users\user\Downloads\llama-cpp-turboquant\build\ggml\src\ggml-cpu.vcxproj]

[NERVxxxx]

Found this fix :
https://github.com/TheTom/llama-cpp-turboquant/pull/37/changes

[TheTom]

Already fixed in tree. ggml/src/ggml-turbo-quant.c has both belt-and-suspenders:

#define _USE_MATH_DEFINES   // line 13
#include <math.h>
...
#ifndef M_PI                // line 19-21 fallback
#define M_PI 3.14159265358979323846
#endif

Pull the latest feature/turboquant-kv-cache and rebuild — the MSVC error C2065 should be gone. Re-open if you still hit it.