Add configurable require_pkce_for hook alongside force_pkce
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new `require_pkce_for` hook that determines, per client, whether
PKCE is required, defaulting to the current `force_pkce` behavior.
You can force PKCE universally with `force_pkce`, or replicate the old behavior
for non-confidential clients using:
`require_pkce_for { |client| client && !client.confidential? }`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a new
require_pkce_forhook that determines, per client, whether PKCE is required, defaulting to the currentforce_pkcebehavior.You can force PKCE universally with
force_pkce, or replicate the old behavior for non-confidential clients using:require_pkce_for { |client| client && !client.confidential? }