Dynamic routing global configuration

[iexapl]

New Features

The GlobalConfiguration JSON section and the Global Configuration Schema include subsections like HttpHandlerOptions, LoadBalancerOptions, QoSOptions, and RateLimitOptions, which can configure Dynamic Routing global options. However, these subsections do not configure static routes' global options or dynamic routes at a per-route level. Therefore, allowing overrides of the Dynamic Routing global configuration is a desirable feature.

[TomPallister]

@iexapl please can you explain what you mean by it didn't work? They will only work if you are using dynamic routing feature with a service discovery provider.

If you can share your whole source code or program.cs / startup.cs and json configuration I can look more!

[iexapl]

For example:

{
  "ReRoutes": [
    {
      "ServiceName": "News",
      "DownstreamPathTemplate": "/{url}",
      "DownstreamScheme": "http",
      "UpstreamPathTemplate": "/News/{url}",
      "UpstreamHttpMethod": [ "Get", "Post", "Delete", "Put" ],
      "UseServiceDiscovery": true,
      "AuthenticationOptions": {
        "AuthenticationProviderKey": "Bearer",
        "AllowedScopes": []
      }
    }
  ],
  "GlobalConfiguration": {
    "BaseUrl": "http://xxx.yyy.com",
    "RequestIdKey": "GatewayRequestId",
    "ServiceDiscoveryProvider": {
      "Host": "localhost",
      "Port": 8500,
      "Type": "PollConsul",
      "PollingInterval": 100
    },
    "LoadBalancerOptions": {
      "Type": "RoundRobin"
    },
    "RateLimitOptions": {
      "ClientIdHeader": "client_id",
      "QuotaExceededMessage": "请求太多!!!",
      "DisableRateLimitHeaders": false,
      "Period": "1s",
      "PeriodTimespan": 15,
      "Limit": 35
    }
  }
}

ServiceName News LoadBalancerOptions should apply the Loadbalanceroptions value in Globalconfiguration, right? But that's not the case.

[TomPallister]

@iexapl the load balancer and rate limit options need to be set in the ReRoute configuration. E.g.

{
    "DownstreamPathTemplate": "/api/posts/{postId}",
    "DownstreamScheme": "https",
    "UpstreamPathTemplate": "/posts/{postId}",
    "UpstreamHttpMethod": [ "Put" ],
    "ServiceName": "product",
    "LoadBalancerOptions": {
        "Type": "LeastConnection"
    },
}

Unfortunately, you cannot do this globally. This will be a new feature. This is where the global load balancer and rate limit options apply.

I will mark this issue as a new feature request and hopefully do it one day, if you would like to attempt to implement this yourself I would really appreciate it! 😄

[garora]

@TomPallister - is this feature still under development?

[TomPallister]

This feature might have been done by the community while I was away from the project. Maybe try test it and let me know.

[AlonMorgen]

any news on that?

[raman-m]

@garora commented on Mar 7, 2020

"Global" LoadBalancerOptions and RateLimitOptions are supported by Dynamic Routing feature.

If you don't use Service Discovery feature, and you still want to define global Rate Limiting, then you need to rework configuration and submit a new PR.

Also, global Rate Limiting options don't have much sense because you limit all routes. I would say that for Microservices architecture this is a bit strange approach to limit all routes the same way... You can organize per-route limiting instead.
Global Rate Limiting makes sense if you sail Ocelot instance per-user to limit the plan of usage.
Also, Rate Limiting is available out of the box in ASP.NET Core 7, see:

• Rate Limiting | Future and ASP.NET Core Implementation