Replace some wikify widget with call dynamic attribute syntax#9816
Merged
Conversation
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2488.9 KB |
| PR | 2488.4 KB |
Diff: ⬇️ Decrease: 0.5 KB
❌ Change Note Status
Change note validation failed. Please fix the following issues:
📄 editions/tw5.com/tiddlers/releasenotes/5.5.0/#9816.tid
- Title format: Expected
$:/changenotes/<version>/<#issue or commit-hash>, found:{value}
📚 Documentation: Release Notes and Changes
Member
|
Thanks @Leilei332 it's great to see those sorts of simplifications. |
pmario
reviewed
Apr 17, 2026
pmario
reviewed
Apr 17, 2026
pmario
reviewed
Apr 17, 2026
pmario
reviewed
Apr 17, 2026
Contributor
|
Oh, we can do this now? Previously doing so will only assign procedure's definition to the variable. In the new version it is its call result? |
Member
|
Thank you @Leilei332. If you could please add a changenote, I would be happy to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces unnecessary wikify widget usage with call dynamic attribute syntax.