Modern theme - adding 7 themes you may or may not like#9890
Modern theme - adding 7 themes you may or may not like#9890BurningTreeC wants to merge 18 commits into
Conversation
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2491.8 KB |
| PR | 2491.7 KB |
Diff: ⬇️ Decrease: 0.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.1/#9890
Type: enhancement | Category: theme
Release: 5.4.1
Add 7 themes, from elegant to opaline
🔗 #9890
👥 Contributors: BurningTreeC
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
|
Nice experiment. |
Thanks. Aren't themes already plugins? 😉 |
This release adds seven new themes, enhancing the visual options available.
|
Yea. sorry. I meant. 3rd party. We already have problems maintaining our existing themes. They are all outdated. We can not handle 7 more |
There was a problem hiding this comment.
IMO this one should be <%if%>, since reveal always creates a DOM element, which can cause trouble with style sheets
| } | ||
| .tc-story-river { width: auto !important; max-width: none !important; margin: 0 !important; padding: 0 !important; } | ||
| .tc-tiddler-frame { | ||
| background: #fff !important; |
There was a problem hiding this comment.
Does print really need !important? If it is the last stylesheet in the row to be active it should do without them. !important will make it close to impossible for users to modify print styling without using !important !important which is the pure horror.
If you move the print CSS at the end of the file it should overwrite everything, which comes prior.
Also if it must have !important for elements that use DOM STYLE, print CSS should be its own tiddler, so users can easily edit it instead of messing it up even more.
|
Thank you @BurningTreeC. I notice that many of the themes include their own palettes. The original idea was that palettes and themes should be orthogonal; users should be able to select them independently. You may already be aware of #8702 which introduces some quite major changes to the way that palettes work. One improvement is a filter operator to compute the contrast between two colours. This allows us to display warnings for colour pairings that have insufficient contrast. If themes really need to introduce a new colour that is not in the standard palettes, then the best approach may be for the palette entries to use these new filter operators to dynamically choose colours that are based on the standard palette entries. It may be worth considering targeting #8702 for these new themes, although I do need to update it from master first. |
3 participants
This PR adds 7 themes.
They use gpu acceleration where possible and sensible.
They ship a
lucidaccessibility theme that comes with two contrast palettes dark and light.They ship a
noirtheme made especially for dark palettes.The other themes need to be explored. I like the workbench a lot.
Let's see