Skip to content

Move background action console.log inside platforms check#9891

Open
linonetwo wants to merge 5 commits into
TiddlyWiki:masterfrom
linonetwo:fix/background-action-log-platforms-check
Open

Move background action console.log inside platforms check#9891
linonetwo wants to merge 5 commits into
TiddlyWiki:masterfrom
linonetwo:fix/background-action-log-platforms-check

Conversation

@linonetwo

@linonetwo linonetwo commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I found this cosole log very annoying, because I already set it to only run on the browser, but it still create a lot of log in the server side.

Now, I make it only log when it's going to really execute it.

Copilot AI review requested due to automatic review settings June 25, 2026 13:34
@netlify

netlify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit df7eb6f
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/6a5778f188525a0007d71d07
😎 Deploy Preview https://deploy-preview-9891--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

📊 Build Size Comparison: empty.html

Branch Size
Base (master) 2491.8 KB
PR 2491.8 KB

Diff: ⬆️ Increase: +0.0 KB


✅ Change Note Status

All change notes are properly formatted and validated!

📝 $:/changenotes/5.5.0/#9891

Type: bugfix | Category: internal
Release: 5.5.0

Move background action log inside platforms check to avoid spurious server-side logs

🔗 #9891

👥 Contributors: linonetwo


📖 Change Note Guidelines

Change notes help track and communicate changes effectively. See the full documentation for details.

@github-actions

Copy link
Copy Markdown

Confirmed: linonetwo has already signed the Contributor License Agreement (see contributing.md)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts background-action processing logging so it only occurs when actions are actually executed (i.e., after the platform gating logic decides doActions is true). This reduces log noise when background actions are suppressed due to a platforms field mismatch.

Changes:

  • Move the "Processing background action" console.log to run only inside the doActions branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@linonetwo linonetwo mentioned this pull request Jul 2, 2026
@saqimtiaz saqimtiaz moved this to Needs feedback in Planning for v5.5.0 Jul 12, 2026
@saqimtiaz saqimtiaz moved this from Needs feedback to Ready in Planning for v5.5.0 Jul 14, 2026
@saqimtiaz

Copy link
Copy Markdown
Member

@linonetwo could you please update the release note to target v5.5.0? Thank you.

PR TiddlyWiki#9891 is still open, so the background-action log change is planned for 5.5.0 instead of 5.4.1.
 is not a valid category; use  instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

3 participants