Wrap hardlinebreaks regions in a void node#9924
Draft
pmario wants to merge 1 commit into
Draft
Conversation
Preserve the rule names of the nodes inside a """ hard linebreaks region. Fixes TiddlyWiki#9906. * Return one void wrapper spanning the region, as styleblock does; the rule name lands on the wrapper and the inner nodes keep their own. Void nodes are a rendering pass-through, so output is unchanged * Stamp the synthesized br elements explicitly and retire the isRuleStart/isRuleEnd flags from TiddlyWiki#8258 * Adapt the wikitext-serialize rule to the wrapper shape Compatibility: region content is nested one level deeper and the flags (shipped in v5.4.0) are gone. Practical risk is low; the only known consumer is the wikitext-serialize plugin, adapted here.
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2492.6 KB |
| PR | 2492.7 KB |
Diff: ⬆️ Increase: +0.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.5.0/#9906
Type: bugfix | Category: developer
Release: 5.5.0
Hard linebreaks regions keep the rule names of their inner nodes
🔗 #9906
👥 Contributors: pmario
⚠️ Impact: $:/changenotes/5.5.0/#9906/impacts/hardlinebreaks-parse-tree
Impact Type: compatibility-break
Related Change: $:/changenotes/5.5.0/#9906
The parse tree shape of
"""hard linebreak regions has changed
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the rule names of the nodes inside a """ hard linebreaks region.
Compatibility: region content is nested one level deeper and the flags (shipped in v5.4.0) are gone. Practical risk is low; the only known consumer is the wikitext-serialize plugin, adapted here.
Part of #9908.