Annotate the parse tree of quote blocks#9928
Draft
pmario wants to merge 1 commit into
Draft
Conversation
Record the facts about a <<< quote block that existed only in the source: marker depth, user classes, and which cite elements are synthesized. Fixes TiddlyWiki#9911. * Record marker and userClasses on the blockquote node and stamp isQuoteCite on the synthesized cite elements; without them nested quotes emit unparseable <<< at every level and user classes fuse with the synthesized tc-quote * Capture the marker before parsing the body; a nested quote re-enters the same rule instance and overwrites this.match * Note for third-party code: the new fields are purely additive; rendered output is unchanged
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2492.6 KB |
| PR | 2493.0 KB |
Diff: ⬆️ Increase: +0.4 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.5.0/#9911
Type: enhancement | Category: developer
Release: 5.5.0
Quote blocks annotate their parse tree nodes
🔗 #9911
👥 Contributors: pmario
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record the facts about a <<< quote block that existed only in the source: marker depth, user classes, and which cite elements are synthesized.
Part of #9908.