Make block spans and block position consistent#9931
Draft
pmario wants to merge 1 commit into
Draft
Conversation
Cover exactly the block syntax with block node spans and record the parse position; separators live in the gaps. Fixes TiddlyWiki#9914. * Trim one trailing line end run at the block dispatch, never into a child's span; fix the table row and container ends and the typedblock start directly in their rules * Stamp blockPosition beside the rule name; isBlock is untouched for rendering compatibility * Note for third-party code: start/end shift for six block rules (positions shipped in v5.4.0) and block nodes gain blockPosition; rendering is unchanged
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2492.6 KB |
| PR | 2494.7 KB |
Diff: ⬆️ Increase: +2.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.5.0/#9914
Type: bugfix | Category: developer
Release: 5.5.0
Block node spans cover exactly their own syntax and record their parse position
🔗 #9914
👥 Contributors: pmario
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover exactly the block syntax with block node spans and record the parse position; separators live in the gaps.
Part of #9908.