-
Notifications
You must be signed in to change notification settings - Fork 36
Enable python 3.12 #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable python 3.12 #1959
Conversation
See also #1865 |
Reasons why tests were failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe wait for another approval to check my changes.
Please include pytest outputs for 3.12 executions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about fully_trusted
; otherwise LGTM. Thanks @kounelisagis @dudoslav!
Tests run successfully. |
or isinstance(variable.args[0], ast.Constant) | ||
or isinstance(variable.args[0], ast.Constant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh wow
Enable python 3.12 for this repo
[sc-37726]