fix: Load globals that are subclasses or instances of a class being compiled lazily #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiled lazily Previously, the entire global dict was loaded whenever a function was compiled. However, this causes issues if there is a global that is an instance or subclass of a class being compiled, and the class being compiled reference that global. Now, when a class is being compiled, instances and subclasses of that class is excluded and loaded at runtime.
|
zepfred
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the entire global dict was loaded whenever a function was compiled. However, this causes issues if there is a global that is an instance or subclass of a class being compiled, and the class being compiled reference that global.
Now, when a class is being compiled, instances and subclasses of that class is excluded and loaded at runtime.