Skip to content

fix: Stack effect for Python 3.11+ with, ignore missing forward references in type hints, copy extra and function attributes #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Christopher-Chianelli
Copy link
Collaborator

No description provided.

…ences in get_type_hints

- And use object.__getattribute__ instead of getattr when reading
  attributes when copying objects.
…copy to create instances if possible

- Functions are restored by looking up the function with the same
  qualified name

- Extra attributes (that don't correspond to any instance attributes)
  are copied to the Python object

- Use copy to create instances to play nice with complex Python
  classes
- Change PythonIterator to an interface and move its implementation
  to DelegatePythonIterator
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Christopher-Chianelli Christopher-Chianelli merged commit 03dd634 into TimefoldAI:main Jun 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants