Disable timely's default features #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable timely's default features, which means disable getopts, which differential doesn't need. This avoids forcing timely's getopts feature on folks who bring in differential.
|
Looks good; will merge once green (which I expect)! Thanks very much. |
benesch
added a commit
to benesch/differential-dataflow
that referenced
this pull request
Jan 27, 2021
As in TimelyDataflow#297, this makes it possible to use dogsdogsdogs without depending on getopts.
frankmcsherry
pushed a commit
that referenced
this pull request
Jan 27, 2021
As in #297, this makes it possible to use dogsdogsdogs without depending on getopts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing disabling timely's default features (i.e., getopts), though they are still enabled by default.