use PartialOrder implementation where appropriate
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two places had a copy pasted implementation of the PartialOrder logic so this replaces it with calling the appropriate trait implementations Signed-off-by: Petros Angelatos <[email protected]>
| // Test to see if strict progress has occurred, which happens whenever the new | ||
| // frontier isn't equal to the previous. It is only in this case that we have any | ||
| // data processing to do. | ||
| if prev_frontier.borrow() != input.frontier().frontier() { |
There was a problem hiding this comment.
I think this is right. I was a bit confused about the definition of antichain equality, but it looks like the implementation equates two things that have the same elements but in different orders.
frankmcsherry
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two places had a copy pasted implementation of the
PartialOrderlogic so this replaces it with calling the appropriate trait implementations