Skip to content

Log size/capacity/allocations from the merge batchers #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Nov 28, 2023

This logs records/size/capacity/allocation changes from the columnar merge batcher, and only records from the vec-based merge batcher.

@antiguru antiguru force-pushed the batcher_size_logger branch from c75ea12 to e2016ae Compare November 29, 2023 01:21
This logs size/capacity/allocation changes from the columnar merge batcher.

Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru force-pushed the batcher_size_logger branch from e2016ae to b7524c7 Compare December 8, 2023 15:48
@antiguru antiguru changed the title DNM: Log size/capacity/allocations from columnar merge batcher Log size/capacity/allocations from the merge batchers Dec 8, 2023
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, and understandable; thank you!

@frankmcsherry frankmcsherry merged commit 0871fbd into TimelyDataflow:master Dec 8, 2023
@antiguru antiguru deleted the batcher_size_logger branch December 14, 2023 21:10
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants