Skip to content

Introduce trait constraints; simplify elsewhere #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

frankmcsherry
Copy link
Member

This PR introduces constraints to the Time and Diff associated types for TraceReader, BatchReader, and Cursor. They look roughly like so:

    /// Timestamps associated with updates
    type Time: Timestamp + Lattice + Ord + Clone;
    /// Associated update.
    type Diff: Semigroup;

These constraints are .. pretty much the rule now, in use of differential dataflow. Users end up needing to write where clauses with much of this information, even though no one expects to use these things in the absence of these properties.

@frankmcsherry frankmcsherry merged commit 30ac63d into TimelyDataflow:master Dec 23, 2023
@frankmcsherry frankmcsherry deleted the trait_constraints branch December 23, 2023 14:34
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant