Remove ValOwned
#476
Merged
Remove ValOwned
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
commented
Apr 24, 2024
antiguru
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought experiment removing
ValOwnedfrom traces, batches, cursors, etc. It removes any opinions about the owned forms of the value GAT, other than that implied byMyTrait::Owned(which .. can vary as a function of the lifetime, and probably isn't load bearing at this point).The pain here is that you do want some relationship between
VandTr::Val<'a>. All we seem to need is a function from the latter to the former, althoughFromandIntodo not work because they are not implemented for e.g.&TwhereT: Clonewhich we see a lot. Instead, core methods take afrom: Fn(Tr::Val<'_>) -> V, which is not the most ergonomic but seemed better than having an ongoing struggle with new traits.