Replace covariant PartialOrd with reborrow() #500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch containers have required that their items are comparable across lifetimes. This seems to confound Rust when presented with the
Ord
constraint in addition. Another option is to remove the constraint, and require that the contain know how to reborrow its items, narrowing their lifetimes.At the moment this is a thing to consider; there are other ways to achieve the same goal we think (e.g. removing
Ord
instead).cc: @antiguru