Remove worker identifier from logging #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the data received from logging from (Duration, Id, Data) to (Duration, Data), saving the space for Id. In most cases, the Id can be derived from the context where the log data is processed. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
log_identifier
branch
from
d3c3fe1 to
79c0e4a
Compare
antiguru
changed the title
Comment on lines
+23
to
+24
| /// Setup event | ||
| Setup(CommunicationSetup) |
Member
There was a problem hiding this comment.
Are we certain this actually gets constructed anywhere? I didn't see it, but I may have missed it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the data received from logging from (Duration, Id, Data) to
(Duration, Data), saving the space for Id. In most cases, the Id can be
derived from the context where the log data is processed.
Signed-off-by: Moritz Hoffmann [email protected]