Simplify communication Message type
#596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
force-pushed
the
communication_simplify
branch
from
6346187 to
fb23fdc
Compare
antiguru
approved these changes
Nov 10, 2024
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good. Didn't read in detail as I'm on the phone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR chases down some simplifications due to the removal of
abomonation, looking forward to flexibility enabled by containers.Specifically, the
Message<T>type has wrapped several ways to present aT, including owned and borrowed forms, as well as numerous accessors. All of the borrowed forms have been dead code since theabomonationremoval, and the attendant complexity unwarranted. This PR removes it.Going forward, distinctions between owned and borrowed seem best housed in containers, which can themselves resemble
MessageContents<T>which was the enum that could be owned or borrowed. TheMessage<T>type remains, but seemingly only to support serialization methods, but this behavior could be move into a trait that containers are expected to implement if they are to be used for exchange edges.