-
Notifications
You must be signed in to change notification settings - Fork 290
Move opinions about encoding from communication to timely.
#597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opinions about encoding from communication to timely.
#597
Conversation
31f2783 to
1850d8e
Compare
|
One thing I'd should tidy up are the unit tests in the doccomments. I copy/pasted in something that I knew would work, but it is a departure from what was there before. I don't know that they are bad, just .. different unintentionally. |
|
|
antiguru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think this is a worthwhile simplification. Some minor suggestions around leaving out 'static when it's implied by Any. No strong opinion though, it mostly removes some visual clutter.
9d2ac9e to
52a0755
Compare
|
I'll take the |
52a0755 to
b9c3da0
Compare
b9c3da0 to
26e5454
Compare
This PR introduces a trait
Bytesablewith methods from and intoBytes. It removes fromcommunicationany reliance onbincode, not because it is bad just because it is an opinion. It almost removes all dependence onserde, except that it creates several logging types that want to deriveSerializeandDeserialize, but it is not otherwise reliant on them.The trait that was formerly
communication::Datais now insteadcommunication::allocator::Exchangeable, and it looks like so:In exchange, timely gets a relatively small opinion, currently in the
encodingmodule, that one can implementBytesablewith some reliance onserdeandbincode. The opinions are expressed in a traitwhich informs the
timely::ExchangeDatatrait.