refactor: multikey_object proptests #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinyTinni
force-pushed
the
multikey-proptests
branch
4 times, most recently
from
6691737 to
43e11d6
Compare
TinyTinni
force-pushed
the
multikey-proptests
branch
from
43e11d6 to
944ec3a
Compare
TinyTinni
force-pushed
the
multikey-proptests
branch
from
8d22e69 to
81df891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multikey_object types were ignored in proptests so far. The coverage of wchar_t is also not that great.
This PR refactors the code, so that every test can be run against every object and char type (vdf::object, vdf::multikey_object, char, wchar_t) without rewriting/copying it.
The rapidcheck max_successes can be reduced as the coverage increases with tests being run which tests already the similar property (4x1k tests run with 10k tests before).