Chore!: Make default_connection
optional
#4522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now the config's
default_connection
was default initialized to DuckDB for less setup friction.However, if the gateway connection was not configured properly, this could lead to us silently replacing it with DuckDB.
Our tests largely depended on that fact so as to reduce boilerplate code, and by making it optional there were many failures introduced. For that matter, I went ahead and solved it by monkey-patching
Config.get_connection()
.