Fix(mssql): Use truncate+insert for FULL models instead of merge #4531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4472
This PR:
delete_from()
to useTRUNCATE
if there is no WHERE clause. This works because unlike many other databases, truncate works within a transaction on MSSQL and is more efficient than usingDELETE
DELETE+INSERT
strategy instead ofMERGE
if_insert_overwrite_by_condition
is called without a condition._insert_overwrite_by_condition
is used byreplace_table()
which is how theFULL
materialization strategy is implemented.The net result is that full data replacements in existing tables become a lot more efficient