Skip to content

refactor: Add tox_options_set_savedata, deprecate old functions. - #2840

Draft
iphydf wants to merge 1 commit into
TokTok:masterfrom
iphydf:savedata
Draft

iphydf wants to merge 1 commit into
TokTok:masterfrom
iphydf:savedata

Conversation

@iphydf

@iphydf iphydf commented Jan 25, 2025 •

Copy link
Copy Markdown
Member

This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 25, 2025
@github-actions github-actions Bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Jan 25, 2025
@iphydf
iphydf force-pushed the savedata branch 4 times, most recently from 092015c to ce5870d Compare January 25, 2025 15:12
@codecov

codecov Bot commented Jan 25, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (7c9fa37) to head (dabae03).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/tox_options.c 69.56% 7 Missing ⚠️
testing/fuzzing/toxsave_fuzz_test.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
- Coverage   72.14%   72.02%   -0.12%     
==========================================
  Files         152      152              
  Lines       31182    31192      +10     
==========================================
- Hits        22496    22467      -29     
- Misses       8686     8725      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf
iphydf marked this pull request as ready for review January 25, 2025 15:25
@iphydf
iphydf force-pushed the savedata branch 4 times, most recently from 17045ee to 1038738 Compare January 28, 2025 23:52
@Green-Sky Green-Sky modified the milestones: v0.2.21, v0.2.22 Feb 1, 2025
This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.
@iphydf iphydf modified the milestones: v0.2.22, v0.2.23 Jan 27, 2026
@iphydf
iphydf marked this pull request as draft February 9, 2026 08:26
@Green-Sky Green-Sky modified the milestones: v0.2.23, v0.2.24 Apr 13, 2026
sorasoras added a commit to sorasoras/c-toxcore that referenced this pull request Jul 25, 2026
@Green-Sky Green-Sky modified the milestones: v0.2.24, v0.2.25 Aug 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring production code, eg. renaming a variable, not affecting semantics

Development

Successfully merging this pull request may close these issues.

2 participants