Avoid possible lexer truncation warnings#196
Merged
ToruNiina merged 1 commit intoToruNiina:masterfrom Aug 17, 2022
Jajauma:AvoidCharStaticCasts
Merged
Avoid possible lexer truncation warnings#196ToruNiina merged 1 commit intoToruNiina:masterfrom Jajauma:AvoidCharStaticCasts
ToruNiina merged 1 commit intoToruNiina:masterfrom
Jajauma:AvoidCharStaticCasts
Conversation
Instead of static_cast calls that convert int to char, literals of type char are now used directly with the value encoded via escape sequence. The benefits are: - code without static_cast is much more compact and expresses intent better - fixed value truncation warning on some compilers (e.g. C4309 on Visual Studio 2017)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of static_cast calls that convert int to char, literals of type
char are now used directly with the value encoded via escape sequence.
The benefits are:
better
Studio 2017)