Skip to content

joyent/node-http-signature#92 bump min node version to 0.10 and add CI testing #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2019
Merged

joyent/node-http-signature#92 bump min node version to 0.10 and add CI testing #93

merged 3 commits into from
Nov 5, 2019

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Nov 5, 2019

Fixes #92

bahamas10
bahamas10 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@bahamas10 bahamas10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pulled the code and ran make check on my own machine, but that doesn't really exercise the jenkinsfile, but it still looks good.

@trentm trentm merged commit a438c3f into master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahamas10 bahamas10 bahamas10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump min node version to 0.10 and add CI testing
2 participants
@trentm @bahamas10