Skip to content

java7: modernise workflow (replace archived wrapper-validation action)#422

Merged
kplattret merged 5 commits into
mainfrom
java7/replace-archived-wrapper-validation-action
Jun 22, 2026
Merged

java7: modernise workflow (replace archived wrapper-validation action)#422
kplattret merged 5 commits into
mainfrom
java7/replace-archived-wrapper-validation-action

Conversation

@kplattret

Copy link
Copy Markdown
Member

Modernises .github/workflows/java7.yml. Workflow-only — no changes to the java7/ library.

Changes

  • Replace the archived gradle/wrapper-validation-action with its official successor gradle/actions/wrapper-validation, pinned to v6.2.0 (both the build-and-test and publish jobs). The old action's repo is archived and points here.
  • Use the temurin distribution instead of the deprecated adopt alias in actions/setup-java (matches java.yml).
  • Document why the CI matrix is Java 8-only. Java 7 compatibility is already enforced at compile time via targetCompatibility = '1.7', and Java 8 is the lowest JDK that can both run Gradle and execute the tests (Gradle requires Java 8+ to run, and its toolchains don't support Java 7 as a target) — so a real JDK 7 test run isn't possible. The comment prevents a future well-intentioned "add Java 7" change that would hit the Gradle wall.

Note

This intentionally does not bump java7's Gradle (8.0.2) or add multi-runtime testing — that would be a larger, coordinated change to the java7/ build files, best as its own PR.

🤖 Generated with Claude Code

kplattret and others added 3 commits June 19, 2026 17:44
gradle/wrapper-validation-action is archived and superseded by
gradle/actions/wrapper-validation. Switch both usages in java7.yml to the new
action, pinned to v6.2.0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The 'adopt' (AdoptOpenJDK) distribution alias is deprecated in actions/setup-java;
Eclipse Temurin is its successor (and what java.yml already uses).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Java 7 compatibility is enforced at compile time via targetCompatibility = '1.7',
and Java 8 is the lowest JDK that can run Gradle and execute the tests, so a real
JDK 7 test run isn't possible. Add a comment so the matrix isn't "fixed" later by
adding Java 7.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kplattret
kplattret requested a review from a team as a code owner June 19, 2026 17:00
@kplattret
kplattret requested a review from Copilot June 19, 2026 17:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernises the java7 GitHub Actions workflow by updating deprecated/archived CI actions and clarifying the rationale for the Java runtime used in CI, without changing the java7/ library itself.

Changes:

  • Replace archived gradle/wrapper-validation-action with gradle/actions/wrapper-validation pinned to v6.2.0 in both jobs.
  • Switch actions/setup-java distribution from deprecated adopt to temurin.
  • Add an explanatory comment documenting why the CI matrix runs on Java 8 only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/java7.yml Outdated
kplattret and others added 2 commits June 19, 2026 19:06
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@kplattret
kplattret merged commit 602569a into main Jun 22, 2026
7 checks passed
@kplattret
kplattret deleted the java7/replace-archived-wrapper-validation-action branch June 22, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants