Skip to content

Patching YOLO Ultralytics Upgrade #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025

Conversation

kieranfraser
Copy link
Collaborator

@kieranfraser kieranfraser commented Jul 7, 2025

Description

Please include a summary of the change, motivation and which issue is fixed. Any dependencies changes should also be included.

Fixes #2687

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Updated tests/estimators/object_detection/test_pytorch_yolo_loss_wrapper.py

Test Configuration:

  • OS: MacOS
  • Python version: 3.11
  • ART version or commit number: 1.20

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes have been tested using both CPU and GPU devices

…utput format such that loss via ultralytics can be computed.

Signed-off-by: Kieran Fraser <[email protected]>
… yolo feature facilitate many yolo versions to be used via ultralytics.

Signed-off-by: Kieran Fraser <[email protected]>
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (6aba944) to head (cc636c5).
Report is 6 commits behind head on dev_1.20.1.

Files with missing lines Patch % Lines
...tors/object_detection/pytorch_yolo_loss_wrapper.py 0.00% 6 Missing ⚠️
art/estimators/object_detection/pytorch_yolo.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.20.1    #2686      +/-   ##
==============================================
- Coverage       85.12%   84.68%   -0.45%     
==============================================
  Files             328      328              
  Lines           29506    29497       -9     
  Branches         4966     4964       -2     
==============================================
- Hits            25118    24980     -138     
- Misses           2963     3081     +118     
- Partials         1425     1436      +11     
Files with missing lines Coverage Δ
...mators/object_detection/pytorch_object_detector.py 89.11% <100.00%> (+1.74%) ⬆️
art/estimators/object_detection/pytorch_yolo.py 70.68% <0.00%> (ø)
...tors/object_detection/pytorch_yolo_loss_wrapper.py 33.33% <0.00%> (+3.10%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beat-buesser beat-buesser changed the base branch from main to dev_1.20.1 July 7, 2025 16:48
@beat-buesser beat-buesser self-requested a review July 7, 2025 16:48
@beat-buesser beat-buesser self-assigned this Jul 7, 2025
@beat-buesser beat-buesser added the improvement Improve implementation label Jul 7, 2025
@beat-buesser beat-buesser added this to the ART 1.20.1 milestone Jul 7, 2025
@beat-buesser beat-buesser changed the base branch from dev_1.20.1 to main July 7, 2025 17:16
@beat-buesser beat-buesser changed the base branch from main to dev_1.20.1 July 7, 2025 17:16
@beat-buesser beat-buesser marked this pull request as ready for review July 7, 2025 17:20
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kieranfraser Thank you very much for identifying and fixing this bug! The changes look good to me.

@beat-buesser beat-buesser merged commit cc40aae into Trusted-AI:dev_1.20.1 Jul 7, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error executing attack with YOLO (ultralytics) model
2 participants