🐛 Show hidden comments to admin when there are just hidden comments

[kaueburiti]

Context

When the admin hides all comments, it becomes impossible to see the hidden comments, so you can't unhide or even delete them.

fixes #22331

The Solution

As described here by @cathysarisky, the major problem was the AuthFrame not being loaded.

But things get a bit complex when you notice that even after loading it, hidden comments still don't show. We got stuck in the loading state. The reason is that because of the way we update the states inside initSetup, we can never change our done to success, leaving us in an eternal loading state.

So, besides loading the AuthFrame, the major work was handling the state update on initSetup to avoid unnecessary re-renders.

Screenshots

Admin Perspective	Member Perspective

[coderabbitai]

"""

Walkthrough

The changes refactor the initSetup function within the App component to improve state management and data fetching. The function now sets the commentsIsLoading flag to true before initiating concurrent API calls to fetch initialization data and comments using Promise.all. Once both calls resolve, the state is updated with the relevant data, including member information, labs configuration, comments, pagination, and comment count, and the loading flag is set to false. Error handling is also updated to use a functional state update. Additionally, the rendering logic for the <AuthFrame> component has been modified so that it is always rendered, regardless of the number of comments, removing the previous conditional check that only rendered it when comments existed. No changes were made to the signatures of exported or public entities; all modifications are internal to the App component.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure hidden comments are visible to site admins even if all comments are hidden (#22331)	✅
Remove conditional rendering of <AuthFrame> based on comment count (#22331)	✅
Refactor state updates and error handling in initSetup (#22331)	✅
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/comments-ui/test/e2e/admin-moderation.test.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-i18next".

(The package "eslint-plugin-i18next" was not found when loaded as a Node module from the directory "/apps/comments-ui".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-i18next@latest --save-dev

The plugin "eslint-plugin-i18next" was referenced from the config file in "apps/comments-ui/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55d986c and f085bca.

📒 Files selected for processing (1)

• apps/comments-ui/test/e2e/admin-moderation.test.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/comments-ui/test/e2e/admin-moderation.test.ts

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[9larsons]

@kaueburiti Thanks for this, and sorry for the delay!