Skip to content

Fixed domain warming when warming has completed #26817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam-lord merged 1 commit into from
Mar 13, 2026
Merged

Fixed domain warming when warming has completed #26817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions ghost/core/core/server/services/email-service/domain-warming-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,23 @@ export class DomainWarmingService {
*/
async getWarmupLimit(emailCount: number): Promise<number> {
const day = await this.#getDaysSinceFirstEmail();

let limit = 0;

if (day >= this.#warmupConfig.totalDays) {
return Infinity;
// Max limit if we're after the warm-up period
limit = Infinity;
} else {
// Interpolate the warmup amount
limit = Math.round(
this.#warmupConfig.start *
Math.pow(
this.#warmupConfig.end / this.#warmupConfig.start,
day / (this.#warmupConfig.totalDays - 1)
)
);
}

const limit = Math.round(
this.#warmupConfig.start *
Math.pow(
this.#warmupConfig.end / this.#warmupConfig.start,
day / (this.#warmupConfig.totalDays - 1)
)
);

return Math.min(emailCount, limit);
}
}
8 changes: 4 additions & 4 deletions ghost/core/test/unit/server/services/email-service/domain-warming-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ describe('Domain Warming Service', function () {
}
});

it('should return Infinity after warmup period is complete', async function () {
it('should return emailCount after warmup period is complete', async function () {
// After 42 days, warmup is complete
Email = createModelClass({
findAll: [{
Expand All @@ -260,10 +260,10 @@ describe('Domain Warming Service', function () {
});

const result = await service.getWarmupLimit(1000000);
assert.equal(result, Infinity);
assert.equal(result, 1000000);
});

it('should return Infinity well after warmup period is complete', async function () {
it('should return emailCount well after warmup period is complete', async function () {
// After 100 days, warmup should definitely be complete
Email = createModelClass({
findAll: [{
Expand All @@ -278,7 +278,7 @@ describe('Domain Warming Service', function () {
});

const result = await service.getWarmupLimit(1000000);
assert.equal(result, Infinity);
assert.equal(result, 1000000);
});
});
});
Loading