Skip to content

Changed members list page to use ListPage#27964

Merged
peterzimon merged 1 commit into
mainfrom
DES-1378/members-list-page-migration
May 20, 2026
Merged

Changed members list page to use ListPage#27964
peterzimon merged 1 commit into
mainfrom
DES-1378/members-list-page-migration

Conversation

@peterzimon

@peterzimon peterzimon commented May 19, 2026

Copy link
Copy Markdown
Contributor

ref https://linear.app/ghost/issue/DES-1378/members-list-page-migration

  • Migrated the members list screen to the shared Shade ListPage and PageHeader structure.
  • Kept members-specific search, filters, bulk actions, import routing, virtualization, and table rendering intact.
  • Preserved the sticky members table heading behavior with a members-local measurement target, without changing the shared Shade ListPage template.
  • Removed the old members-only page shell components that are no longer used.

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9878dea8-d67d-4613-858e-dd02ac0a69ba

📥 Commits

Reviewing files that changed from the base of the PR and between 615e4ab and af0dbd9.

📒 Files selected for processing (5)
  • apps/posts/src/views/members/components/members-content.tsx
  • apps/posts/src/views/members/components/members-header.tsx
  • apps/posts/src/views/members/components/members-layout.tsx
  • apps/posts/src/views/members/components/members-list.tsx
  • apps/posts/src/views/members/members.tsx
💤 Files with no reviewable changes (3)
  • apps/posts/src/views/members/components/members-content.tsx
  • apps/posts/src/views/members/components/members-layout.tsx
  • apps/posts/src/views/members/components/members-header.tsx

Walkthrough

This PR rewrites the Members page to use MainLayout + ListPage/PageHeader/FilterBar instead of the legacy MembersLayout/MembersHeader/MembersContent. It updates imports, replaces the header ref with a setHeaderContentRef callback that captures the page header DOM, rebuilds the page header/search/filter/action layout, preserves loading/error/empty/list flows, and adjusts the MembersList scroll-root classes.

Possibly related PRs

  • TryGhost/Ghost#27936: Similar migration of a page (Comments) from bespoke layout/header/content wrappers to MainLayout + ListPage/PageHeader.
  • TryGhost/Ghost#27896: Migrates list pages (Tags) from legacy wrapper components to the shared MainLayout + ListPage + PageHeader composition.
  • TryGhost/Ghost#27860: Related refactor aligning Members header rendering to the updated PageHeader/FilterBar composition.

Suggested reviewers

  • weylandswart
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: migrating the members list page to use the ListPage component structure.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, detailing the migration to ListPage/PageHeader and the removal of legacy components.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DES-1378/members-list-page-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterzimon peterzimon changed the title [codex] Changed members list page to use ListPage Changed members list page to use ListPage May 19, 2026
@peterzimon peterzimon marked this pull request as ready for review May 19, 2026 09:57
@peterzimon peterzimon requested a review from weylandswart May 19, 2026 09:57

@weylandswart weylandswart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looks good to me 👍

@peterzimon peterzimon force-pushed the DES-1378/members-list-page-migration branch from b46118d to 615e4ab Compare May 20, 2026 06:26
ref https://linear.app/tryghost/issue/DES-1378/

This completes the current admin list page migration sweep by moving members onto the shared Shade ListPage and PageHeader structure while keeping the members-specific table, filters, and sticky heading behavior local to the screen.
@peterzimon peterzimon force-pushed the DES-1378/members-list-page-migration branch from 615e4ab to af0dbd9 Compare May 20, 2026 08:04
@peterzimon peterzimon enabled auto-merge (squash) May 20, 2026 08:08
@peterzimon peterzimon merged commit a088e9c into main May 20, 2026
72 of 74 checks passed
@peterzimon peterzimon deleted the DES-1378/members-list-page-migration branch May 20, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants