Changed members list page to use ListPage#27964
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
WalkthroughThis PR rewrites the Members page to use MainLayout + ListPage/PageHeader/FilterBar instead of the legacy MembersLayout/MembersHeader/MembersContent. It updates imports, replaces the header ref with a setHeaderContentRef callback that captures the page header DOM, rebuilds the page header/search/filter/action layout, preserves loading/error/empty/list flows, and adjusts the MembersList scroll-root classes. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
weylandswart
left a comment
There was a problem hiding this comment.
Nice one, looks good to me 👍
b46118d to
615e4ab
Compare
ref https://linear.app/tryghost/issue/DES-1378/ This completes the current admin list page migration sweep by moving members onto the shared Shade ListPage and PageHeader structure while keeping the members-specific table, filters, and sticky heading behavior local to the screen.
615e4ab to
af0dbd9
Compare
ref https://linear.app/ghost/issue/DES-1378/members-list-page-migration
ListPageandPageHeaderstructure.ListPagetemplate.