Skip to content

🎨 Added warning and filter for members with multiple active subscriptions#28508

Merged
kevinansfield merged 2 commits into
mainfrom
duplicate-subscription-warning
Jun 11, 2026
Merged

🎨 Added warning and filter for members with multiple active subscriptions#28508
kevinansfield merged 2 commits into
mainfrom
duplicate-subscription-warning

Conversation

@kevinansfield

@kevinansfield kevinansfield commented Jun 11, 2026

Copy link
Copy Markdown
Member

closes https://linear.app/ghost/issue/BER-3721/

Members with multiple active Stripe subscriptions are usually paying twice without realising it, and until now there was no easy way for site owners to spot them. The Members list now shows a banner whenever any members have multiple active subscriptions, with a link to filter down to the affected members so the duplicates can be resolved. How it works is documented in the duplicate subscription warning help doc.

closes https://linear.app/ghost/issue/BER-3721/

- the Members list now shows a banner whenever members have multiple active Stripe subscriptions, with a link to view the affected members so duplicate payments can be resolved — see https://ghost.org/help/duplicate-subscription-warning/ for details
- the feature was complete behind the GA'd `multipleSubsFilter` labs flag, so the flag and its conditionals have been removed to finish the rollout
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR deprecates the multipleSubsFilter feature flag by removing it from the GA features registry and eliminating the corresponding multipleSubsFilterEnabled prop from the Members page component. The MultipleActiveSubscriptionsBanner rendering condition is simplified to depend solely on hasStripeEnabled, removing the additional feature flag gate.

Possibly related PRs

  • TryGhost/Ghost#28232: Adds the MultipleActiveSubscriptionsBanner with multipleSubsFilter lab flag gating and the filter UI behavior that this PR deprecates.
  • TryGhost/Ghost#28507: Fixes the backend query for computing active Stripe customer counts, which affects the data displayed by the multiple subscriptions banner being ungated in this PR.

Suggested reviewers

  • 9larsons
  • jonatansberg
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes adding a warning and filter for members with multiple subscriptions, but the PR actually removes the feature flag and associated conditionals to complete a rollout—not add new functionality. Update the title to reflect the actual change: something like 'Remove multipleSubsFilter GA flag to complete rollout' or 'Graduate multiple subscriptions warning from experimental to default'.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the changeset, explaining the removal of the multipleSubsFilter GA flag and clarifying that the feature is now fully rolled out.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch duplicate-subscription-warning

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield changed the title 🎨 Added a warning for members with duplicate active subscriptions 🎨 Added warning and filter for members with duplicate active subscriptions Jun 11, 2026
@kevinansfield kevinansfield enabled auto-merge (squash) June 11, 2026 14:36
ref https://linear.app/ghost/issue/BER-3721/

- the snapshot asserts a fixed content-length for the settings edit response, which shrank when the multipleSubsFilter flag was removed from the labs config
@kevinansfield kevinansfield changed the title 🎨 Added warning and filter for members with duplicate active subscriptions 🎨 Added warning and filter for members with multiple active subscriptions Jun 11, 2026
@kevinansfield kevinansfield disabled auto-merge June 11, 2026 15:08
@kevinansfield kevinansfield enabled auto-merge (squash) June 11, 2026 15:09
@kevinansfield kevinansfield merged commit 0274b81 into main Jun 11, 2026
49 checks passed
@kevinansfield kevinansfield deleted the duplicate-subscription-warning branch June 11, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant