Changed members Stripe customer count filter to an NQL aggregate relation#28547
Merged
Conversation
Contributor
WalkthroughThis PR removes custom query handling for count.active_stripe_customers and replaces it with a declarative aggregate and nql filter expansion on the Member model. Serializer extraction/validation and repository option handling for activeStripeCustomersCount are removed. E2E tests are updated for filter composition and non-numeric validation. Dependency pins for Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/activitypub |
✅ Succeeded | 3s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/sodo-search |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/admin-toolbar |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 9m 49s | View ↗ |
Additional runs (15) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-12 17:34:48 UTC
kevinansfield
force-pushed
the
members-aggregate-customer-count-filter
branch
2 times, most recently
from
34e71cc to
f0ee2e5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28547 +/- ##
==========================================
- Coverage 73.76% 73.76% -0.01%
==========================================
Files 1541 1541
Lines 132282 132252 -30
Branches 15852 15853 +1
==========================================
- Hits 97584 97557 -27
- Misses 33713 33730 +17
+ Partials 985 965 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…tion ref https://linear.app/ghost/issue/BER-3717/ ref TryGhost/NQL#152 - the `count.active_stripe_customers` filter was hardcoded outside of NQL: the input serializer pattern-matched the exact filter string and the member model injected a bespoke knex subquery, so the filter only worked in the exact `count.active_stripe_customers:>1` form and 400'd when combined with any other filter or comparison - mongo-knex now supports a native `aggregate` relation type, so the filter is defined as a regular `active_stripe_customers_count` filter relation on the member model and composes with other filters like any other NQL filter; the public filter key is unchanged via a filter expansion - non-numeric values fail closed inside mongo-knex and still surface as 400s - `@tryghost/mongo-knex` is temporarily resolved from a local checkout of the NQL branch via a pnpm `link:` override until it's published
ref TryGhost/NQL#152 - the aggregate relation support is now published as nql 0.13.0 / mongo-knex 0.10.0, so the temporary pnpm `link:` override pointing at a local NQL checkout is no longer needed - bookshelf-filter pins nql@0.12.10 exactly, so nql is force-resolved to the catalog version via a pnpm override to make sure filter queries are built with aggregate relation support - removed the nql@0.12.10 packageExtension as nothing resolves that version anymore and 0.13.0 declares its lodash dependency properly
kevinansfield
force-pushed
the
members-aggregate-customer-count-filter
branch
from
f0ee2e5 to
74d97aa
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ghost/core/core/server/services/members/members-api/repositories/member-repository.js`:
- Around line 966-969: The 400 error is misleading because the guard checks for
either filter or search but the thrown message uses
messages.bulkActionRequiresFilter only; update the thrown error so the message
references both "filter" and "search" (e.g., use or create a
messages.bulkActionRequiresFilterOrSearch key or change the tpl call to include
search) where the code throws in member-repository.js (the if block checking
filter, search, all) so the processLogger/error text reflects "filter, search,
or all=true" when calling tpl(messages.bulkActionRequiresFilter..., {action:
'bulk edit'}).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a208eb59-7df6-4a14-9bbe-1578291c9218
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
ghost/core/core/server/api/endpoints/utils/serializers/input/members.jsghost/core/core/server/models/member.jsghost/core/core/server/services/members/members-api/repositories/member-repository.jsghost/core/test/e2e-api/admin/members.test.jspnpm-workspace.yaml
💤 Files with no reviewable changes (1)
- ghost/core/core/server/api/endpoints/utils/serializers/input/members.js
ref #28547 (comment) - the bulk edit/delete guards accept a filter, search, or all=true but the 400 error message only mentioned filter and all=true, making it misleading for callers using search
…ride ref #28547 - bookshelf-filter 2.2.4 now depends on nql 0.13.0 directly, so filter queries get aggregate relation support without force-resolving nql via a pnpm override
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ghost/core/package.json`:
- Line 96: The package.json entry for "`@tryghost/bookshelf-plugins`": "2.2.4"
relies on a transitive dependency "`@tryghost/nql`@0.13.0" (via
"`@tryghost/bookshelf-filter`@2.2.4"); add an explicit dependency for
"`@tryghost/nql`": "0.13.0" to ghost/core/package.json to ensure the required
version is declared directly and avoid relying on transitive resolution; update
the dependencies block where "`@tryghost/bookshelf-plugins`" is declared and run
install to verify.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 95baa41c-668d-4bbb-be0b-36f3ceee9f6d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
ghost/core/package.jsonpnpm-workspace.yaml
💤 Files with no reviewable changes (1)
- pnpm-workspace.yaml
kevinansfield
added a commit
that referenced
this pull request
Jun 16, 2026
closes https://linear.app/ghost/issue/BER-3720/ The multiple active subscriptions filter was only reachable through the warning banner's "View members" link and was deliberately hidden from the filter bar, because the API only accepted the one hardcoded `count.active_stripe_customers:>1` filter string — exposing it in the UI would have produced unrepresentable or broken states. With #28547 making the filter a composable NQL field, that restriction is gone, so this makes it behave like any other members filter: - "Multiple active subscriptions" appears in the Subscription filter group directly after "Member status", as a Yes/No select following the same pattern as the comments moderation "Reported" filter. Yes serializes to `count.active_stripe_customers:>1`; No inverts it to `count.active_stripe_customers:<2` to find unaffected members. - It now shows as a normal removable filter chip and can be combined with other filters — including when arriving via the banner's "View members" link, which previously landed on a filtered list with an invisible filter applied. - Following the same conditional pattern as the "Offer" filter, it's only offered when relevant: the count-only query that drives the warning banner is now shared (extracted to `useMultipleActiveSubscriptionsCount`) and fetched once at page level, and the filter stays hidden while that count is zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/BER-3717/
ref TryGhost/NQL#152
The
count.active_stripe_customersmembers filter was hardcoded outside of NQL — the input serializer pattern-matched the exact filter string and the member model injected a bespoke knex subquery. That meant the filter only worked in the exactcount.active_stripe_customers:>1form: combining it with any other filter, or using any other comparison, returned a 400, so it couldn't be composed like a normal members filter.TryGhost/NQL#152 added a native
aggregaterelation type to mongo-knex (published as nql 0.13.0 / mongo-knex 0.10.0). This PR removes all of the hardcoded plumbing (serializer extraction, custom model query, repository special-casing) and defines the filter as a regularactive_stripe_customers_countaggregate relation on the member model. The publiccount.active_stripe_customersfilter key is unchanged — a filter expansion maps it onto the relation — so existing API consumers are unaffected, but the filter now composes with other filters and supports all numeric comparisons. Non-numeric values fail closed inside mongo-knex and still surface as 400s.Note:
@tryghost/bookshelf-pluginsis bumped to 2.2.4 so thatbookshelf-filter— the package that builds filter queries — depends on nql 0.13.0 and gets aggregate relation support.