Remove comments UI action any types#28851
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Walkthrough
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/comments-ui:test:acceptance |
✅ Succeeded | 47s | View ↗ |
nx run-many -t test:unit -p @tryghost/comments-ui |
✅ Succeeded | 12s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 5s | View ↗ |
nx run-many -t lint -p @tryghost/comments-ui |
✅ Succeeded | 5s | View ↗ |
nx run ghost:build:assets |
✅ Succeeded | 2s | View ↗ |
nx run ghost:build:tsc |
✅ Succeeded | 6s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-25 19:04:32 UTC
Changelog for v1.5.14 -> 1.5.17:
f0309bf to
1597986
Compare
# Conflicts: # apps/comments-ui/package.json
1597986 to
c8b95b4
Compare

Please take a minute to explain the change you're making:
apps/comments-ui/src/actions.tshad several explicitanytypes in action payloads and dispatcher casts. This PR removes them so the action layer is better typed.addReplywithAddCommentandComment.parent_id,in_reply_to_id) toAddComment, matching how reply creation already uses that payload shape.SyncActions as anylookup withObject.prototype.hasOwnProperty.call.ActionHandlerandSyncActionHandlerpayloads from the existingActions/SyncActionsmaps instead of acceptingdata: any.adminApifromhideCommentandshowCommentparameter annotations because those functions never destructure or read that argument; they usestate.adminApiinstead, so deleting the unused parameter type is safe and does not change runtime behavior.Please check your PR against these items:
Testing
CI=true pnpm --filter @tryghost/comments-ui exec eslint src/actions.ts src/app-context.tsCI=true pnpm --filter @tryghost/comments-ui exec tsc --noEmittasks/comments-ui-tsc-types.md, but the after result is cleaner: the previoussrc/actions.tserrors are gone andactions.tsno longer appears in the failure list.